Parameter types in the JavaScript domain have erroneous brackets

[AA-Turner]

Reported in https://github.com/orgs/sphinx-doc/discussions/13216 by @resnickj

^{Originally posted by resnickj January 7, 2025}
This can be seen right on the Sphinx documentation page for the JavaScript domain: https://www.sphinx-doc.org/en/master/usage/domains/javascript.html

I'm working on a particular set of docs which were last built with Sphinx 3.5, and it did not output parentheses after parameter types. Was this change made intentionally? (I'm not sure why it would ever make sense to have parentheses after parameter type names.) Is there a way to revert to the old behaviour?

Thanks!

[picnixz]

I think it's because we specify 'class': JSXRefRole(fix_parens=True) instead of fix_parens=False (which is what the Python domain does). Since the types are rendered as if they were class references, they get an additional () suffix). I need to check this but I guess that's one reason.

EDIT: ok it's not that. But looking at the HTML we have:

<code class="xref js js-func docutils literal notranslate"><span class="pre">string()</span></code>

so string is treated as a js-func. I'll investigate more.

EDIT 2: Found a fix.

[picnixz]

The issue is with JSCallable:

    doc_field_types = [
        TypedField(
            'arguments',
            label=_('Arguments'),
            names=('argument', 'arg', 'parameter', 'param'),
            typerolename='func',
            typenames=('paramtype', 'type'),
        ),
        GroupedField(
            'errors',
            label=_('Throws'),
            rolename='func',
            names=('throws',),
            can_collapse=True,
        ),
   ...

The role is func instead of class. But changing it into class leads to lots of not-found references. Could be fine to change it but this could annoy existing builds, so we could first suppress the reference errors arising from those places (it surprises me though that the func role didn't actually lead to ref errors as well).