-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add issue and pull request templates #121
chore: Add issue and pull request templates #121
Conversation
7a23024
to
e97a048
Compare
You didn't open an issue for this PR *scnr* :) |
FYI you can install the |
@Holzhaus do you mind if I exclude the templates from the markdown checks? I'd also add a short contributing.md and the Contributor Covenant as a Code of Conduct to fulfill the GitHub Community Standards. |
Depends. In general we should only exclude files if we have a good reason. Could you elaborate why you think this is necessary in this case?
Ok, thanks. |
The rule violations boil down to:
Alternatively we could create a custom ruleset for these files, but I think that would be overkill for something that will likely never change again… |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's fix MD026 (see above).
The reasoning regarding MD002, MD022 and MD012 make sense to me. You can add an exception by adding something like exclude: ^\.github/.*\.md$
to the markdownlint
hook in .pre-commit-config.yaml
.
.github/ISSUE_TEMPLATE/bug_report.md
Outdated
Note: Please search the issue tracker to see if the bug you've encountered has already been reported. | ||
--> | ||
|
||
### Current Behavior: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove the trailing punctuation. It's not needed here and also inconsistent with the feature request template, where there are no colons.
.github/ISSUE_TEMPLATE/bug_report.md
Outdated
### Expected Behavior: | ||
<!-- A concise description of what you expected to happen. --> | ||
|
||
### To Reproduce: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### To Reproduce: | |
### Reproduction Steps |
.github/ISSUE_TEMPLATE/bug_report.md
Outdated
Example: | ||
- OS: Ubuntu 20.04 | ||
- Python: 3.11.3 | ||
- Project Version: 0.2.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Project Version: 0.2.4 | |
- Project Version (or commit ID): 0.2.4 |
The rule violations boil down to: - MD002 First header should be a top level header: This makes no sense / looks very awkward in issue or PR descriptions. - MD022 Headers should be surrounded by blank lines: It feels overly verbose to separate the comments from the headers given that there is no actual content here. Also remember this has to fit into the GitHub comment box, i.e. vertical space shouldn't be wasted if possible. - MD026 Trailing punctuation in header: I can remove the colons from the issue template headers, but I think they make sense in this case - MD012 Multiple consecutive blank lines: I left the newlines, because the user would have to always add them anyways. Ref: sphinx-contrib#121
e97a048
to
d59abf7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, waiting for CI.
All passed, thank you very much! |
No description provided.