Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add issue and pull request templates #121

Merged
merged 2 commits into from
Oct 6, 2024

Conversation

BurningEnlightenment
Copy link
Member

No description provided.

Holzhaus
Holzhaus previously approved these changes Oct 6, 2024
@Holzhaus
Copy link
Collaborator

Holzhaus commented Oct 6, 2024

You didn't open an issue for this PR *scnr* :)

@Holzhaus Holzhaus dismissed their stale review October 6, 2024 15:23

pre-commit.ci failure

@Holzhaus
Copy link
Collaborator

Holzhaus commented Oct 6, 2024

FYI you can install the pre-commit tool and then run pre-commit install inside the git repo once to ensure that the changes you are about to commit pass the linters locally before pushing them.

@BurningEnlightenment
Copy link
Member Author

@Holzhaus do you mind if I exclude the templates from the markdown checks?

I'd also add a short contributing.md and the Contributor Covenant as a Code of Conduct to fulfill the GitHub Community Standards.

@Holzhaus
Copy link
Collaborator

Holzhaus commented Oct 6, 2024

@Holzhaus do you mind if I exclude the templates from the markdown checks?

Depends. In general we should only exclude files if we have a good reason. Could you elaborate why you think this is necessary in this case?

I'd also add a short contributing.md and the Contributor Covenant as a Code of Conduct to fulfill the GitHub Community Standards.

Ok, thanks.

@BurningEnlightenment
Copy link
Member Author

Depends. In general we should only exclude files if we have a good reason. Could you elaborate why you think this is necessary in this case?

The rule violations boil down to:

  • MD002 First header should be a top level header: This makes no sense / looks very awkward in issue or PR descriptions.
  • MD022 Headers should be surrounded by blank lines: It feels overly verbose to separate the comments from the headers given that there is no actual content here. Also remember this has to fit into the GitHub comment box, i.e. vertical space shouldn't be wasted if possible.
  • MD026 Trailing punctuation in header: I can remove the colons from the issue template headers, but I think they make sense in this case
  • MD012 Multiple consecutive blank lines: I left the newlines, because the user would have to always add them anyways.

Alternatively we could create a custom ruleset for these files, but I think that would be overkill for something that will likely never change again…

Copy link
Collaborator

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix MD026 (see above).

The reasoning regarding MD002, MD022 and MD012 make sense to me. You can add an exception by adding something like exclude: ^\.github/.*\.md$ to the markdownlint hook in .pre-commit-config.yaml.

Note: Please search the issue tracker to see if the bug you've encountered has already been reported.
-->

### Current Behavior:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the trailing punctuation. It's not needed here and also inconsistent with the feature request template, where there are no colons.

### Expected Behavior:
<!-- A concise description of what you expected to happen. -->

### To Reproduce:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### To Reproduce:
### Reproduction Steps

Example:
- OS: Ubuntu 20.04
- Python: 3.11.3
- Project Version: 0.2.4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Project Version: 0.2.4
- Project Version (or commit ID): 0.2.4

The rule violations boil down to:
- MD002 First header should be a top level header: This makes no sense /
        looks very awkward in issue or PR descriptions.
- MD022 Headers should be surrounded by blank lines: It feels overly
        verbose to separate the comments from the headers given that
        there is no actual content here. Also remember this has to fit
        into the GitHub comment box, i.e. vertical space shouldn't be
        wasted if possible.
- MD026 Trailing punctuation in header: I can remove the colons from the
        issue template headers, but I think they make sense in this case
- MD012 Multiple consecutive blank lines: I left the newlines, because
        the user would have to always add them anyways.

Ref: sphinx-contrib#121
Copy link
Collaborator

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for CI.

@Holzhaus
Copy link
Collaborator

Holzhaus commented Oct 6, 2024

All passed, thank you very much!

@Holzhaus Holzhaus merged commit 27132f6 into sphinx-contrib:main Oct 6, 2024
11 checks passed
@BurningEnlightenment BurningEnlightenment deleted the dev/templates branch October 6, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants