support property retry events for extension-specific properties #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extension will update page properties under a get-then-update process, where a retry attempt will be made to help deal with conflict scenarios. This only applied to Confluence-specific properties and not this extension's custom property (e.g. used for page hash tracking). This commit is updated the implementation to perform the get-then-update with retries for all property submissions, in attempt to prevent odd publish scenarios for users. Signed-off-by: James Knight <git@jdknight.me>
A new change [1] results in at least two property fetch events on a page update. Updating the expected results on some unit tests to indicate the expected communication events. [1]: e715ed8 Signed-off-by: James Knight <git@jdknight.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extension will update page properties under a get-then-update process, where a retry attempt will be made to help deal with conflict scenarios. This only applied to Confluence-specific properties and not this extension's custom property (e.g. used for page hash tracking).
This commit is updated the implementation to perform the get-then-update with retries for all property submissions, in attempt to prevent odd publish scenarios for users.