env: maintain tracked page identifier cache between builds #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a cache is kept for tracking previously published pages and their identifiers, if a processing event results in pages not needing to be updated, unchanged pages can cause their page identifiers to be removed from the active list. This can result in a following pass to cleanup legacy-flagged pages for pages that are still considered unchanged. The cache implementation should be maintaining the assumed cached identifier for pages if they remain changed for a run. Updating the implementation to always populate the cached page identifiers before replacing them with new active page identifiers (if any). Signed-off-by: James Knight <git@jdknight.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a cache is kept for tracking previously published pages and their identifiers, if a processing event results in pages not needing to be updated, unchanged pages can cause their page identifiers to be removed from the active list. This can result in a following pass to cleanup legacy-flagged pages for pages that are still considered unchanged.
The cache implementation should be maintaining the assumed cached identifier for pages if they remain changed for a run. Updating the implementation to always populate the cached page identifiers before replacing them with new active page identifiers (if any).