Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

builder: use pathlib for internal imgmath override #1077

Merged
merged 1 commit into from
Jan 30, 2025
Merged

builder: use pathlib for internal imgmath override #1077

merged 1 commit into from
Jan 30, 2025

Conversation

jdknight
Copy link
Member

Updating the internal overwrite of the imgmath temporary directory to use the pathlib module. Upstream version of Sphinx has updated its implementation to use pathlib, and using a str causes issues when running the imgmath extension.

Using Path should be fine for existing/older versions of Sphinx, as its value used with os.path.join handles Path objects.

@jdknight
builder: use pathlib for internal imgmath override
0fbee50 
Updating the internal overwrite of the imgmath temporary directory to
use the pathlib module. Upstream version of Sphinx has updated its
implementation to use pathlib, and using a str causes issues when
running the imgmath extension.

Using `Path` should be fine for existing/older versions of Sphinx, as
its value used with `os.path.join` handles `Path` objects.

Signed-off-by: James Knight <git@jdknight.me>
@jdknight jdknight merged commit b6fd092 into main Jan 30, 2025
29 checks passed
@jdknight jdknight deleted the use-pathlib-for-imgmath-override branch January 30, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jdknight