From 5c3039f194d9b867367ac4486e5b0a9900491342 Mon Sep 17 00:00:00 2001 From: Daniel Dale Date: Fri, 18 Oct 2024 10:20:19 -0700 Subject: [PATCH] update github actions env setting logic, move one test to standalone due to runner issue --- .github/workflows/ci_test-full.yml | 4 ++-- tests/test_finetuning_scheduler_callback.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci_test-full.yml b/.github/workflows/ci_test-full.yml index d14c3ae..5ecbc12 100644 --- a/.github/workflows/ci_test-full.yml +++ b/.github/workflows/ci_test-full.yml @@ -56,10 +56,10 @@ jobs: timeout-minutes: 90 env: # workaround for macos tokenizers https://github.com/neonbjb/tortoise-tts/issues/728#issuecomment-1962438240 - RUSTFLAGS: ${{ matrix.os == 'macOS-14' && '-A invalid_reference_casting' || '' }} + RUSTFLAGS: ${{ (matrix.os == 'macOS-14' && '-A invalid_reference_casting') || '' }} # TODO: Remove this and enable running MPS tests the macos runners support it: # https://github.com/actions/runner-images/issues/9918#issuecomment-2149336099 - DISABLE_MPS: ${{ matrix.os == 'macOS-14' && '1' || '0' }} + DISABLE_MPS: ${{ (matrix.os == 'macOS-14' && '1') || '0' }} steps: - uses: actions/checkout@v4 diff --git a/tests/test_finetuning_scheduler_callback.py b/tests/test_finetuning_scheduler_callback.py index 71b2cf0..dfd124a 100644 --- a/tests/test_finetuning_scheduler_callback.py +++ b/tests/test_finetuning_scheduler_callback.py @@ -1545,7 +1545,7 @@ def test_fts_intrafit(tmpdir, restore_best: bool): } -@RunIf(skip_windows=True, skip_mac_os=True, min_torch="2.4.0", min_python="3.12") +@RunIf(skip_windows=True, skip_mac_os=True, min_torch="2.4.0", min_python="3.12", standalone=True) @pytest.mark.parametrize("restore_best", [True, False], ids=["default", "norestorebest"]) def test_fts_dynamo_intrafit(tmpdir, boring_ft_schedule, restore_best: bool): """Inspect scheduled fine-tuning state within the training process to ensure it is taking the expected path in