Skip to content

Commit

Permalink
update github actions env setting logic, move one test to standalone …
Browse files Browse the repository at this point in the history
…due to runner issue
  • Loading branch information
speediedan committed Oct 18, 2024
1 parent 9e13ece commit 5c3039f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci_test-full.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,10 @@ jobs:
timeout-minutes: 90
env:
# workaround for macos tokenizers https://github.com/neonbjb/tortoise-tts/issues/728#issuecomment-1962438240
RUSTFLAGS: ${{ matrix.os == 'macOS-14' && '-A invalid_reference_casting' || '' }}
RUSTFLAGS: ${{ (matrix.os == 'macOS-14' && '-A invalid_reference_casting') || '' }}
# TODO: Remove this and enable running MPS tests the macos runners support it:
# https://github.com/actions/runner-images/issues/9918#issuecomment-2149336099
DISABLE_MPS: ${{ matrix.os == 'macOS-14' && '1' || '0' }}
DISABLE_MPS: ${{ (matrix.os == 'macOS-14' && '1') || '0' }}
steps:
- uses: actions/checkout@v4

Expand Down
2 changes: 1 addition & 1 deletion tests/test_finetuning_scheduler_callback.py
Original file line number Diff line number Diff line change
Expand Up @@ -1545,7 +1545,7 @@ def test_fts_intrafit(tmpdir, restore_best: bool):
}


@RunIf(skip_windows=True, skip_mac_os=True, min_torch="2.4.0", min_python="3.12")
@RunIf(skip_windows=True, skip_mac_os=True, min_torch="2.4.0", min_python="3.12", standalone=True)
@pytest.mark.parametrize("restore_best", [True, False], ids=["default", "norestorebest"])
def test_fts_dynamo_intrafit(tmpdir, boring_ft_schedule, restore_best: bool):
"""Inspect scheduled fine-tuning state within the training process to ensure it is taking the expected path in
Expand Down

0 comments on commit 5c3039f

Please sign in to comment.