Skip to content

Commit

Permalink
fix: upgrade vale (#31)
Browse files Browse the repository at this point in the history
  • Loading branch information
caroldelwing authored Dec 9, 2024
1 parent 6c599b4 commit b13a106
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ concurrency:
cancel-in-progress: true

env:
VALE_VERSION: "3.8.0"
VALE_VERSION: "3.9.1"

jobs:
run-ci:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/vale.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ on:
inputs:
version:
description: "The version of the Vale to use"
default: "3.8.0"
default: "3.9.1"
type: string
required: false

Expand Down
13 changes: 12 additions & 1 deletion scripts/check_rule.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,19 @@

set -e


failed_tests=0

check_vale_installation() {
if command -v vale &> /dev/null
then
echo "✅ Vale is installed."
else
echo "❌ Vale is not installed."
echo "ℹ️ Use 'brew install vale' to install it with Homebrew."
exit 1
fi
}

# Function to get the last directory name from a given path. This is used to get the rule name.
get_last_directory_name() {
dir_path=$1
Expand Down Expand Up @@ -106,6 +116,7 @@ check_fail_conditions() {
# This function traverses the base directory and checks the pass and fail conditions for the Vale rules.
traverse_and_check() {
base_directory=$1
check_vale_installation

# Traverse the packages directory and look one level down
for package_dir in "$base_directory"/*; do
Expand Down

0 comments on commit b13a106

Please sign in to comment.