Fix(Navisworks): CNX-1329 - Fix Saved Sets Filter to Properly Handle Nested Folders #631
+59
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated exception messages to be more informative based on visibility settings. - Simplified the logic for throwing exceptions when no model items are found.
- Introduced new methods for collecting saved sets and building hierarchical names. - Simplified selection set resolution with a more concise approach. - Updated initialisation of items to use arrays instead of lists. - Improved error handling when resolving GUIDs for selection sets.
jsdbroughton
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #631 +/- ##
=====================================
Coverage 8.71% 8.71%
=====================================
Files 227 227
Lines 4370 4370
Branches 545 545
=====================================
Hits 381 381
Misses 3974 3974
Partials 15 15 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
NavisworksSavedSetsFilterclass only retrieves saved sets at the top level and doesn't correctly handle selection sets within folders. TheIndexOfGuidmethod also fails to find selection sets within nested folders.Changes
GetSavedSets()to recursively collect all saved sets from all folders in the hierarchy>" as the separator to show the folder hierarchyIndexOfGuidusage withResolveGuidon the root document object to properly locate saved sets regardless of their position in the folder structureImplementation
ResolveGuidmethodThis update ensures users can select and use saved sets anywhere in the folder structure, not just at the root level.