Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle-able Basit Mode #3672

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Toggle-able Basit Mode #3672

merged 3 commits into from
Dec 12, 2024

Conversation

AlexandruPopovici
Copy link
Contributor

Description & motivation

Handles https://linear.app/speckle/issue/WEB-2324/add-basit-mode-to-the-toggle-able-view-modes

  • BasitPass now overrides the batchMaterial, not the entire material list so that selection/other stuff works properly
  • The colors proxy values are only applied to meshes, and everything else is kept the same render-wise

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

Copy link
Contributor

📸 Preview service has generated an image.

@KatKatKateryna
Copy link
Contributor

awesome

KatKatKateryna
KatKatKateryna previously approved these changes Dec 12, 2024
Copy link
Contributor

@KatKatKateryna KatKatKateryna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-native speakers friendly, otherwise great 🙌

Copy link
Contributor

📸 Preview service has generated an image.

@AlexandruPopovici AlexandruPopovici merged commit 60ff23d into main Dec 12, 2024
28 of 30 checks passed
@AlexandruPopovici AlexandruPopovici deleted the alex/basit-mode-updates branch December 12, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants