Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log response body on error #1643

Open
gjedlicska opened this issue Jun 22, 2023 · 1 comment
Open

Log response body on error #1643

gjedlicska opened this issue Jun 22, 2023 · 1 comment
Assignees
@iainsproat
Labels
enhancement New feature or request question

Comments

@gjedlicska
Copy link
Contributor

Whenever we return a 4** or 5** status code from the server, we should include the response body with the log message. It helps a lot with diagnosing issues.
@gjedlicska gjedlicska added enhancement New feature or request question labels Jun 22, 2023
@iainsproat
Copy link
Contributor

The response body may contain tokens or GDPR related material (e.g. email), which we would not want persisted in logs. Do we just wish a particular path to be logged if it exists, e.g. .error_message or similar?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iainsproat iainsproat

Labels
enhancement New feature or request question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iainsproat @gjedlicska