Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recovery of commit selection doesn't work if the user hasn't explicitly selected a branch #204

Closed
JR-Morgan opened this issue Jul 23, 2024 · 4 comments · Fixed by #206
Closed
Labels
bug Something isn't working
Milestone

Comments

@JR-Morgan
Copy link
Member

If the user hasn't explicitly set a branch, and instead they let it default to main,
then the branch/commit recovery does not work.

Case 1: working as expected

  1. Select a branch from the drop down (any branch, even the already selected "main", but you must select one explicitly)
  2. Select a commit that isn't the latest one
  3. Refresh stream
  4. Observe, selection has persisted as expected

Case 2: not working as expected, branch & commit selection reset to main+latest

  1. Select a commit that isn't the latest one
  2. Refresh stream
  3. Observe, selection has been changed to latest commit
@JR-Morgan JR-Morgan added the bug Something isn't working label Jul 23, 2024
@JR-Morgan JR-Morgan modified the milestones: 2.10, 2.20 Jul 23, 2024
@JR-Morgan
Copy link
Member Author

@overengineer any chance you're interested in taking a look at this issue?

If not, no worries, I'm happy to take a look.
Ideally we'd fix this before making the 2.20 release so this one is higher priority than #205 or #200

@overengineer
Copy link
Contributor

I fixed this bug with 1993180

@JR-Morgan
Copy link
Member Author

@overengineer amazing thank you, do you mind making a PR

@overengineer
Copy link
Contributor

#206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants