Update docstring of connexion.ConnexionMiddleware.add_api
#2030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisinmtown
suggested changes
Jan 23, 2025
Actually this PR only updates the docstring of the function, and not the function itself. The function still returns nothing, but the docstring said that it actually returned something, which can be confusing (and I can confirm because I got confused by it 😅) |
|
You're right, I misread your PR, thanks for clarifying. +1 from me! |
chrisinmtown
approved these changes
Jan 23, 2025
Ruwann
reviewed
Feb 1, 2025
Ruwann
approved these changes
Feb 1, 2025
|
Pipeline fails due to some unrelated issue (for some reason, mypy is checking some files in a transitive dependency that got recently added) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
connexion.ConnexionMiddleware.add_apito match return value to actual return.