Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in variable and protected method names #177

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

bact
Copy link
Collaborator

@bact bact commented Dec 16, 2024

  • variable: packagComparers -> packageComparers
    • This variable is internal, it is safe to be renamed
  • protected method: exludeFilesToString -> excludeFilesToString
    • This method is protected, only accessible to within the same package and by subclasses
    • If there is a known subclass of org.spdx.tools.compare.PackageSheet accessing this method, outside of this package, it may not safe to be renamed
    • The file method is available since 23 Sep 2020

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@goneall
Copy link
Member

goneall commented Dec 16, 2024

protected method: exludeFilesToString -> excludeFilesToString

This should be safe - I don't know of anyone extending the protected compare classes. Since we are introducing a lot of breaking changes with the spec 3 update, this is a good time to make these changes.

Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @bact

@goneall goneall merged commit db2926f into spdx:master Dec 16, 2024
1 check passed
@bact bact deleted the fix-code-typos-internal branch December 16, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants