Allow to show emails (not just when log driver) #373
+106
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks very nice! The tests are failing. It might be good to do a framework version check and only use the new way of detecting mails for the versions of the framework that support it. |
|
Nice! Haven't got the time to test this out yet, but won't mails in Laravel 11 and above be logged twice? Once via this new watcher, and once via the log? |
|
Please check the latest commit. Before we start 'watching' the emails, the LoggedMailWatcher is disabled. When we stop, it gets re-enabled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works similarly to the showJobs functionality.