Update DbDumperFactory.php #1841
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix for spatie#1840 ability to use skip SSL
riasvdv
requested changes
Sep 20, 2024
| @@ -47,6 +47,7 @@ public static function createFromConnection(string $dbConnectionName): DbDumper | |||
|
|
|||
| if ($dbDumper instanceof MySql) { | |||
| $dbDumper | |||
| ->setSkipSsl($dbConfig['dump']['skipSsl'] ?? false) | |||
There was a problem hiding this comment.
Can you use skip_ssl instead as the other config options use underscores, can you also add this to the docs?
There was a problem hiding this comment.
done, also remember to merge this spatie/db-dumper#213 if not it won't work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #1840
ability to use skip SSL