Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: php 8.4 deprecation warnings #1351

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

ashleyshenton
Copy link
Contributor

I noticed this deprecation warning when using the package with PHP 8.4

Deprecated: activity(): Implicitly marking parameter $logName as nullable is deprecated, the explicit nullable type must be used instead

I have updated all places I can see where the implicit nullable declaration was used. This includes an example in the documentation.

@Nielsvanpach
Copy link
Member

Thanks!

@Nielsvanpach Nielsvanpach merged commit 9abddaa into spatie:main Nov 18, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants