Regenerate pest snapshot for Argentina / Generate pest snapshot for Indonesia test #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chore: Generate pest snap for Indonesia test
|
@Nielsvanpach dunno if a test like this would be helpfull too ensure on next PRs that the dates added to a country follow the proper format. Akrista@02f85b3 We could also add a test to ensure that the resulting date from the holiday array is on the year or period selected. Let me now if you want me to help with some of this best regards |
|
Thanks! And yes, feel free to PR. Why is Sri Lanka ignored? |
|
@Nielsvanpach Sri Lanka throws InvalidCountry by default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following: