From f769a043486bf1aab8ce8a488122556d7cc723be Mon Sep 17 00:00:00 2001 From: Mike Dalessio Date: Mon, 16 Dec 2024 12:56:19 -0500 Subject: [PATCH 1/2] doc: fix typo in CHANGELOG [skip ci] --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 30b3c04490..7effa5c588 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,7 +4,7 @@ Nokogiri follows [Semantic Versioning](https://semver.org/), please see the [REA --- -## 1.18.0.rc1 / 2024-12-16 +## v1.18.0.rc1 / 2024-12-16 ### Notable Changes From 8c6b0b466ea4775c20f53bcd497681dc2f09a2f5 Mon Sep 17 00:00:00 2001 From: Mike Dalessio Date: Fri, 20 Dec 2024 13:52:27 -0500 Subject: [PATCH 2/2] style: address compiler warnings in the gumbo source --- gumbo-parser/src/ascii.c | 4 ++-- gumbo-parser/src/parser.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/gumbo-parser/src/ascii.c b/gumbo-parser/src/ascii.c index 35c4278a99..f656476da6 100644 --- a/gumbo-parser/src/ascii.c +++ b/gumbo-parser/src/ascii.c @@ -44,8 +44,8 @@ const unsigned char _gumbo_ascii_table[0x80] = { }; // Table generation code. -// clang -DGUMBO_GEN_TABLE=1 ascii.c && ./a.out && rm a.out -#if GUMBO_GEN_TABLE +// clang -DGUMBO_GEN_TABLE ascii.c && ./a.out && rm a.out +#ifdef GUMBO_GEN_TABLE #include int main() { diff --git a/gumbo-parser/src/parser.c b/gumbo-parser/src/parser.c index 06f096f8dd..96e6f2bdbe 100644 --- a/gumbo-parser/src/parser.c +++ b/gumbo-parser/src/parser.c @@ -318,7 +318,7 @@ static GumboNode* create_node(GumboNodeType type) { return node; } -static GumboNode* new_document_node() { +static GumboNode* new_document_node(void) { GumboNode* document_node = create_node(GUMBO_NODE_DOCUMENT); document_node->parse_flags = GUMBO_INSERTION_BY_PARSER; gumbo_vector_init(1, &document_node->v.document.children); @@ -1997,7 +1997,7 @@ static void adjust_svg_tag(GumboToken* token) { assert(token->type == GUMBO_TOKEN_START_TAG); if (token->v.start_tag.tag == GUMBO_TAG_FOREIGNOBJECT) { assert(token->v.start_tag.name == NULL); - token->v.start_tag.name = "foreignObject"; + token->v.start_tag.name = (char *)"foreignObject"; } else if (token->v.start_tag.tag == GUMBO_TAG_UNKNOWN) { assert(token->v.start_tag.name); const StringReplacement *replacement = gumbo_get_svg_tag_replacement(