Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ext: revert hacks for GNU/Musl compatibility #3384

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

flavorjones
Copy link
Member

What problem is this PR intended to solve?

Over time, we've accumulated a couple of hacks specifically aimed at improving the compatibility of the -linux native gem on Musl systems.

With #3375 we're building separate -linux-gnu and -linux-musl gems, so these hacks should no longer be needed. Let's remove them.

Have you included adequate test coverage?

We're testing on a matrix that includes Musl systems, so existing coverage should be adequate.

Does this change affect the behavior of either the C or the Java implementations?

N/A

Introduced in 0b49210 for gnu/musl cross-compatibility
@flavorjones flavorjones mentioned this pull request Dec 16, 2024
14 tasks
this reverts a change from 004e6a6 / #3031 that prevented an
unresolved symbol on Musl when running the generic Linux native gem.
@flavorjones flavorjones merged commit 6b81ce1 into main Dec 16, 2024
145 checks passed
@flavorjones flavorjones deleted the flavorjones-remove-musl-compat-hacks branch December 16, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant