fix: Node#dup adds the new node to the document's node cache
#3363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to make sure it's marked properly. Also, we make sure the new node is decorated if necessary with its document's decorators. Fixes #3359 Co-authored-by: Jean Boussier <jean.boussier@gmail.com>
flavorjones
force-pushed
the
flavorjones-fix-node-dup
branch
from
c06a980 to
c72503a
Compare
byroot
added a commit
to rails/rails
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Node#dupadds the new node to the document's node cache to make sure it's marked properly. Fixes #3359.Also, we make sure the new node is decorated if necessary with its document's decorators.
Have you included adequate test coverage?
Yes! HUGE thanks to @byroot for doing the work to create a tight reproduction. 🙇
Does this change affect the behavior of either the C or the Java implementations?
Both bugfixes affect the C implementation only.