Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates HTML5::Document.parse with keyword arguments; #3334

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

infews
Copy link
Contributor

@infews infews commented Nov 14, 2024

What problem is this PR intended to solve?
Keyword arguments for HTML5::Document.parse, etc.

Have you included adequate test coverage?
YAS.

Does this change affect the behavior of either the C or the Java implementations?

@flavorjones flavorjones added the event/hackday2024 RubyConf 2024 Hack Day label Nov 15, 2024
@flavorjones flavorjones added this to the v1.17.0 milestone Nov 29, 2024
@flavorjones flavorjones self-assigned this Nov 29, 2024
@flavorjones
Copy link
Member

Thanks for your patience. The last couple of weeks have been really busy, but I'm hoping to review and merge this in the next week or so!

@flavorjones
Copy link
Member

Rebased, added some tests and tidied up the HTML5::Document docs.

@flavorjones flavorjones enabled auto-merge December 6, 2024 22:09
@flavorjones flavorjones disabled auto-merge December 6, 2024 22:49
@flavorjones flavorjones merged commit 7b87461 into sparklemotion:main Dec 6, 2024
129 of 131 checks passed
@flavorjones
Copy link
Member

See also #3355

flavorjones added a commit that referenced this pull request Dec 8, 2024
…ke keyword arguments (#3355)

**What problem is this PR intended to solve?**

As part of #3323 there were a few RubyConf 2024 Hack Day pull requests
addressing Document and DocumentFragment constructors which were related
to, or blocked on, some changes to the C code.

So this PR is a mega-PR that merges all those PRs and unifies the code
and doc style:

- #3327 
- #3336 
- #3334 
- #3335 

But in addition to those PRs also updates:

- the `XML::DocumentFragment` new/initialize argument handling for CRuby
and JRuby
- `XML::DocumentFragment#initialize` kwargs
- `HTML4::Document.parse` kwargs
- general improvement of documentation

**Have you included adequate test coverage?**

I think so!

**Does this change affect the behavior of either the C or the Java
implementations?**

The XML::DocumentFragment allocator has changed, but both
implementations have been updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
event/hackday2024 RubyConf 2024 Hack Day
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants