fix: strip spaces from the operator when translating nth css to xpath #3018
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Prevent errors when nokogiri is translating nth css to xpath and there are spaces in it. (E.g.
2n + 1
instead of2n+1
)Background: This came up because prettier started rewriting my email css from
li:nth-child(2n+1)
toli:nth-child(2n + 1)
(which is perfectly valid in browsers) and this caused aexpected an+b node to have either + or - as the operator, but is " + " (ArgumentError)
error from https://github.com/Mange/roadie using nokogiri as part of inlining the css.Have you included adequate test coverage?
I believe so!
Does this change affect the behavior of either the C or the Java implementations?
Since I only modified ruby code, I'm assuming not?