Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): update rubocop-minitest requirement from 0.32.2 to 0.33.0 #3012

Merged
merged 2 commits into from
Oct 29, 2023
Merged

build(deps-dev): update rubocop-minitest requirement from 0.32.2 to 0.33.0 #3012

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25136ab
build(deps-dev): update rubocop-minitest requirement
dependabot[bot] Oct 23, 2023
98326be
style(rubocop): Minitest/AssertEqual and Minitest/RefuteEqual
flavorjones Oct 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ group :development do
# rubocop
if Gem::Requirement.new("~> 3.0").satisfied_by?(Gem::Version.new(RUBY_VERSION))
gem "rubocop", "1.57.1"
gem "rubocop-minitest", "0.32.2"
gem "rubocop-minitest", "0.33.0"
gem "rubocop-packaging", "0.5.2"
gem "rubocop-performance", "1.19.1"
gem "rubocop-rake", "= 0.6.0"
Expand Down
2 changes: 1 addition & 1 deletion test/xml/test_node.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1511,7 +1511,7 @@ def test_serialize_unparented_node
if Nokogiri.uses_libxml?
doc = Nokogiri::XML(xml, &:nobig_lines)
node = doc.at_css("x")
assert_operator(node.line, :==, max_short_int)
assert_equal(node.line, max_short_int)
end

doc = Nokogiri::XML(xml)
Expand Down
12 changes: 6 additions & 6 deletions test/xml/test_node_set.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,31 +284,31 @@ def awesome(ns)
assert(node_set_one = xml.xpath("//employee"))
assert(node_set_two = xml.xpath("//employee"))

refute_operator(node_set_one.object_id, :==, node_set_two.object_id)
refute_equal(node_set_one.object_id, node_set_two.object_id)
refute_same(node_set_one, node_set_two)

assert_operator(node_set_one, :==, node_set_two)
assert_operator(node_set_one, :==, node_set_two) # rubocop:disable Minitest/AssertEqual
end

it "handles comparison to a string" do
node_set_one = xml.xpath("//employee")
refute_operator(node_set_one, :==, "asdfadsf")
refute_operator(node_set_one, :==, "asdfadsf") # rubocop:disable Minitest/RefuteEqual
end

it "returns false if same elements are out of order" do
one = xml.xpath("//employee")
two = xml.xpath("//employee")
two.push(two.shift)
refute_operator(one, :==, two)
refute_operator(one, :==, two) # rubocop:disable Minitest/RefuteEqual
end

it "returns false if one is a subset of the other" do
node_set_one = xml.xpath("//employee")
node_set_two = xml.xpath("//employee")
node_set_two.delete(node_set_two.first)

refute_operator(node_set_one, :==, node_set_two)
refute_operator(node_set_two, :==, node_set_one)
refute_operator(node_set_one, :==, node_set_two) # rubocop:disable Minitest/RefuteEqual
refute_operator(node_set_two, :==, node_set_one) # rubocop:disable Minitest/RefuteEqual
end
end

Expand Down
Loading