Add a note that NOKOGIRI_USE_SYSTEM_LIBRARIES is used by TruffleRuby #2085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit ceda534 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 94.3%. View more on Code Climate. |
|
✅ Build nokogiri 1.0.682 completed (commit 46b4726493 by @eregon) |
|
👍 Thanks for the attention. I chatted with @chrisseaton a week or two ago about getting a TR build in Nokogiri's CI pipelines (https://ci.nokogiri.org/teams/nokogiri-core/pipelines/nokogiri), which will help ensure we don't break anything. |
|
If you’ve come here from the TruffleRuby source, please see #2191. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/oracle/truffleruby/blob/d0c380361d65fd9cc89f98efdf7c7f956f073720/lib/mri/mkmf.rb#L52-L54
I'll add a note in the TruffleRuby code that once we solve this we can remove the comment here too.
It's not so trivial to solve, so I think it's worthwhile adding a comment here.
Potentially compiling libxml2 with the GraalVM LLVM toolchain might allow using static libraries, but that would then mean running all of libxml2 in Sulong (instead of precompiled native code) which needs to be evaluated if it works and if it's fast.