-
-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop support for Ruby 3.0, add support for Ruby 3.4 #3273
Comments
This is just one perspective I’d like to share. When I tried using the preview version of Ruby, I encountered a build error in the Linux distribution: bundle install
(snip)
Fetching gem metadata from https://rubygems.org/..........
nokogiri-1.17.1-x86_64-linux requires ruby version >= 3.0, < 3.4.dev, which is incompatible with the current version, 3.4.0.preview2 https://rubygems.org/gems/nokogiri/versions/1.17.1-x86_64-linux Nokogiri holds an important position in the Ruby ecosystem, and it would be beneficial if installation errors due to required Ruby versions did not occur with the preview version. Early adopters aiming to detect issues early would likely want to start testing the behavior after successfully installing Nokogiri as soon as possible. Thank you. |
@koic This is a known limitation in bundler and not an issue with Nokogiri. You can delete your |
See rubygems/rubygems#6237 for an example of a similar bug report to bundler. |
Just to clarify: "add support for Ruby 3.4" in this issue means "add precompiled libraries for Ruby 3.4 to the native gems". Ruby 3.4 is already supported, we run CI with ruby-head. But you must install the non-native gem. |
I see! Thank you for the clear explanation, and for always keeping things well-maintained! |
This issue will be closed by #3376 |
I've released v1.18.0.rc1 with native gems containing Ruby 3.4-compatible libraries. https://github.com/sparklemotion/nokogiri/releases/tag/v1.18.0.rc1 |
Ruby 3.0 was EOL 23 Apr 2024. Nokogiri's policy is to support the current and previous three versions of Ruby, so we won't drop support until Ruby 3.4 is released.
Tagging this for v1.18.0 which will coincide with Ruby 3.4.0 final release in Dec 2024.
This will likely happen in v1.18 release candidates earlier than December.
required_ruby_version
to">= 3.1.0"
TargetRubyVersion
to"3.1"
The text was updated successfully, but these errors were encountered: