Skip to content

Commit

Permalink
ci: checkouts@v4 needs a more modern glibc than rcd has
Browse files Browse the repository at this point in the history
so let's run the key step in the container instead of the whole job.
  • Loading branch information
flavorjones committed Sep 14, 2023
1 parent 2adedd4 commit 1248316
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -401,8 +401,6 @@ jobs:
needs: ["rcd_image_version"]
name: "generic-package"
runs-on: ubuntu-latest
container:
image: "ghcr.io/rake-compiler/rake-compiler-dock-image:${{needs.rcd_image_version.outputs.rcd_image_version}}-mri-x86_64-linux"
steps:
- uses: actions/checkout@v4
with:
Expand All @@ -412,7 +410,12 @@ jobs:
with:
path: ports/archives
key: tarballs-ubuntu-${{hashFiles('dependencies.yml', 'patches/**/*.patch')}}
- run: ./scripts/test-gem-build gems ruby
- env:
DOCKER_IMAGE: "ghcr.io/rake-compiler/rake-compiler-dock-image:${{needs.rcd_image_version.outputs.rcd_image_version}}-mri-x86_64-linux"
run: |
docker run --rm -v "$(pwd):/nokogiri" -w /nokogiri \
${DOCKER_IMAGE} \
./scripts/test-gem-build gems ruby
- uses: actions/upload-artifact@v3
with:
name: generic-gem
Expand Down

0 comments on commit 1248316

Please sign in to comment.