Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#563 이벤트 코드 활성화 #564

Merged
merged 3 commits into from
Feb 11, 2025
Merged

Conversation

thxx132
Copy link
Contributor

@thxx132 thxx132 commented Feb 8, 2025

이전 이벤트 코드를 활성화 했습니다.
env 파일에
EVENT_CONFIG={"mode":"default","period":{"startAt":"2025-02-08T18:25:53Z","endAt":"2025-02-15T18:25:53Z"}}
와 같이 임의로 이벤트 기간을 추가 작성해 실행할 수 있습니다.

@thxx132 thxx132 linked an issue Feb 8, 2025 that may be closed by this pull request
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/services/users.ts Outdated Show resolved Hide resolved
@kmc7468
Copy link
Member

kmc7468 commented Feb 9, 2025

CI 통과를 못했는데, pnpm test 실행하셔서 오류가 발생하면 해당 부분도 수정이 필요할 것 같습니다. pnpm test 실행을 위해 .env.test 파일이 필요한데, 기존 env 파일 복사해서 만들어주시면 됩니다. (설정에 따라 test 실행시 db가 초기화될 수 있습니다.)

@kmc7468 kmc7468 self-requested a review February 11, 2025 13:49
Copy link
Member

@kmc7468 kmc7468 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 수고하셨습니다~~

@thxx132 thxx132 merged commit b7d9389 into dev Feb 11, 2025
1 check passed
@thxx132 thxx132 deleted the 563-이벤트-코드-활성화 branch February 11, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

이벤트 코드 활성화
2 participants