chore: simplify selected departments comparison logic

sparcs-kaist · May 23, 2024 · dc61799 · dc61799
1 parent 1115a90
commit dc61799
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/src/components/sections/account/FavoriteDepartmentsSubSection.tsx b/src/components/sections/account/FavoriteDepartmentsSubSection.tsx
@@ -36,12 +36,10 @@ const FavoriteDepartmentsSubSection = () => {
     return null;
   }
 
+  // TODO: Change comparison logic
   const hasChange =
-    new Set(user.favorite_departments.map((d) => d.id.toString())).size !==
-      selectedDepartments.size ||
-    [...new Set(user.favorite_departments.map((d) => d.id.toString()))].some(
-      (d) => !selectedDepartments.has(d),
-    );
+    user.favorite_departments.length !== selectedDepartments.size ||
+    user.favorite_departments.some(({ id }) => !selectedDepartments.has(id.toString()));
 
   return (
     <div className={classNames('subsection', 'subsection--favorite-department')}>