Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main으로 push한 수정사항을 dev에도 반영 #220

Merged
merged 3 commits into from
Aug 31, 2024

Conversation

sangohkim
Copy link
Collaborator

@sangohkim sangohkim commented Aug 30, 2024

Overview

  1. PostWritePage에서 첨부파일에 대한 request url을 정상적으로 복구함
  2. Android Target API 버전을 33에서 34로 상향
  3. 사용하지 않는 패키지인 flutter_local_notification을 제거함

Changes

Implementaion Method

post_write_page.dart, build.gradle 수정함

After Changes

Related Issues

Rollback Scenario

TODO

dev로 머지한 후 PostWritePage 관련 다른 기능들에서 발생하던 에러가 여전히 나타나는지 확인해보아야함.
Flutter 버전을 3.22 정도로 상향시키는 작업이 필요할듯(점점 iOS, Android 모두 플러터 3.13이 타겟팅하는 버전대와는 멀어지는 현상)

@sangohkim sangohkim self-assigned this Aug 30, 2024
@sangohkim sangohkim added the bug Something isn't working label Aug 30, 2024
@sangohkim sangohkim added this to the v1.2.0 milestone Aug 30, 2024
@sangohkim sangohkim marked this pull request as ready for review August 30, 2024 08:45
@sangohkim sangohkim changed the title Fix: main으로 push한 수정사항을 dev에도 반영 Aug 30, 2024
Copy link
Contributor

@thomaskim1130 thomaskim1130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomaskim1130 thomaskim1130 merged commit 571dab6 into dev Aug 31, 2024
2 checks passed
@thomaskim1130 thomaskim1130 deleted the fix/request-url-target-api branch August 31, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants