195 decorate last item message #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
마지막 페이지(게시물)에서 _loadNextPage()를 호출할 시, 따로 처리해 _isLastItem에 저장하도록 함. Next Page가 api 상에서 존재하지 않을 시 CastError가 호출되는 것을 catch하고, 이후 LoadingIndicator()를 대신하여 표시됨.
_isLastItem 이 True일 때, context.locale 을 참조하여 메시지를 번역하도록 함.
postListShowPage에서 _loadNextPage()가 호출되었을 때, 로딩에 성공한다면 _isLastItem=false로 설정함. reloading 후에도 _isLastItem=true로 유지되는 현상을 해결함.
Resolved conflicts with origin/dev
update to dev
thomaskim1130
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
It closes #195
Changes
Implementaion Method
After Changes
Related Issues
Rollback Scenario
TODO