-
-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for structured scaffold in create command #970
base: main
Are you sure you want to change the base?
feat: support for structured scaffold in create command #970
Conversation
for more information, see https://pre-commit.ci
@pre-commit-ci[bot] is attempting to deploy a commit to the sparckles Team on Vercel. A member of the Team first needs to authorize it. |
CodSpeed Performance ReportMerging #970 will not alter performanceComparing Summary
|
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@sansyrox lmk if you have any suggestions for the scaffold structure |
I'll fix the issues in the create script to make sure tests are passing tomorrow morning |
Hey @ashupednekar 👋 Thank you for the PR 😄 But the ci is failing. Could you please have a look? |
for more information, see https://pre-commit.ci
Hi, the new flag wasn't being passed in the create_robyn test, added that, with one new test for the new path, it says CI (tests) waiting for approval. What should I do? Did it cross some limit on number of test runs? |
for more information, see https://pre-commit.ci
…scaffold (for ruff xP)
for more information, see https://pre-commit.ci
Hey @VishnuSanal , can you review this PR? |
the functionality looks good in the first look. works as expected. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ashupednekar 👋
Great work. Overall the PR looks very promising. I have some initial feedback
class SampleHandlers: | ||
@router.post("/one") | ||
@staticmethod | ||
def one(): ... | ||
|
||
@router.get("/two") | ||
@staticmethod | ||
def two(): ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we confining the two methods in a namespace?
@@ -0,0 +1 @@ | |||
SERVICE_PORT=3000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is this being used
@@ -0,0 +1,117 @@ | |||
# A generic, single database configuration. | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add this
Alembic is a database migrations tool written by the author of SQLAlchemy. A migrations tool offers the following functionality:
@ashupednekar , we would also have to add some documentation in the website somewhere before we merge the PR. |
Agreed 👍 |
Description
This PR fixes #969
Summary
PR: Add Structured Scaffold Option to Robyn's Create Command
Description:
This PR introduces a new feature to Robyn's
create
command, allowing users to choose between two scaffold options:Changes:
create
command to prompt users with a new option:Would you like the scaffold to be a simple starter kit or an opinionated structure?
api/handlers
(for route handlers)middlewares
(for middleware definitions)adaptors
(withmodels
,selectors
,mutators
)utils
(helper functions likedb.py
)devops
(including Dockerfile, docker-compose)conf.py
,config.env
).Example Structured Scaffold:
PR Checklist
Please ensure that:
Pre-Commit Instructions: