Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: async shutdown handler not getting called #965

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

VishnuSanal
Copy link
Contributor

Description

This PR fixes #964

Summary

This PR does fix async shutdown handler not getting called

PR Checklist

Please ensure that:

  • The PR contains a descriptive title
  • The PR contains a descriptive summary of the changes
  • You build and test your changes before submitting a PR.
  • You have added relevant documentation
  • You have added relevant tests. We prefer integration tests wherever possible

Pre-Commit Instructions:

Copy link

vercel bot commented Sep 20, 2024

@VishnuSanal is attempting to deploy a commit to the sparckles Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codspeed-hq bot commented Sep 20, 2024

CodSpeed Performance Report

Merging #965 will not alter performance

Comparing VishnuSanal:fix-shutdown-handler (8dcae24) with main (028f161)

Summary

✅ 116 untouched benchmarks

@sansyrox sansyrox marked this pull request as ready for review September 23, 2024 15:03
robyn/cli.py Show resolved Hide resolved
src/server.rs Outdated Show resolved Hide resolved
@VishnuSanal
Copy link
Contributor Author

note to self: Sanskar taking this over after discussion in the meeting. :)

@VishnuSanal
Copy link
Contributor Author

VishnuSanal commented Sep 28, 2024

  • fix crash event loop already runnign

@VishnuSanal VishnuSanal marked this pull request as draft September 28, 2024 07:55
@VishnuSanal
Copy link
Contributor Author

VishnuSanal commented Sep 30, 2024

current issues:

  • have to press ctrl + c twice for an app with async shutdown handler to quit when running as cli
  • dev server doesn't get terminated properly -- the post is occupied the next time the app runs (when using with async shutdown handler)

@VishnuSanal VishnuSanal marked this pull request as ready for review October 2, 2024 18:47
@sansyrox
Copy link
Member

sansyrox commented Oct 6, 2024

Hey @VishnuSanal ,

There are some conflicts. Can you have a look again?

@VishnuSanal
Copy link
Contributor Author

@sansyrox PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shutdown handler not working
2 participants