Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: request body parsing #956

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: request body parsing #956

wants to merge 4 commits into from

Conversation

tqq1994516
Copy link

@tqq1994516 tqq1994516 commented Aug 30, 2024 •
edited
Loading

Description

This PR fixes #954

Summary

  1. Add serde_urlencoded dependencies to parse simple form data
  2. Update request.form_data for parsing of simple form data
  3. Add simple form data case
  4. Use Value to PyDict instead of the default turn String
  5. Replace the form_data type
  6. Add form_data transformation logic
  7. Replace the files type
  8. Use Value to restore the original structure of files
  9. Add files transformation logic

PR Checklist

Please ensure that:

  • The PR contains a descriptive title
  • The PR contains a descriptive summary of the changes
  • You build and test your changes before submitting a PR.
  • You have added relevant documentation
  • You have added relevant tests. We prefer integration tests wherever possible

Pre-Commit Instructions:

@tqq1994516
fix(types): [cr_id_skip] Fix simple form parse
6465a04 
Add serde_urlencoded dependencies to parse simple form data
Update `request.form_data` for parsing of simple form data
Add simple form data case
@tqq1994516
fix(types): [cr_id_skip] Update form_data and json parsing
b062374 
Use Value to PyDict instead of the default turn String
Replace the form_data type
Add form_data transformation logic
@tqq1994516
fix(types): [cr_id_skip] Update files parsing
73155f3 
Use Value to restore the original structure of files
@vercel Vercel
Copy link

vercel bot commented Aug 30, 2024

@tqq1994516 is attempting to deploy a commit to the sparckles Team on Vercel.

A member of the Team first needs to authorize it.

@tqq1994516 tqq1994516 mentioned this pull request Aug 30, 2024
Open
@tqq1994516
chore(python): [cr_id_skip] Update request field type description
1b215f4 
Update request.form_data type description
Update request.files type description
tqq1994516
tqq1994516 commented Sep 4, 2024
View reviewed changes
Copy link
Author

@tqq1994516 tqq1994516 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@sansyrox
Copy link
Member

sansyrox commented Sep 4, 2024

Thanks @tqq1994516 , I will have a look 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

robyn request body processing problem
2 participants
@tqq1994516 @sansyrox