Why does collect() silently ignore unexpected positional args?
#545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Opening a PR for this because it is the easiest way to see if the added test still fails with latest sparta without creating an updated env locally. I would expect that `pevent.collect()` should throw if called positional arguments that are: * unexpected (i.e. the pevent wasn't defined to take any positional args) * mismatching type (as it looks like compilation doesn't catch this) - didn't commit the test I added for this in this commit * what other sanity checking is feasible? The test added in this PR shows that we can call `collect()` with positional args for events that haven't registered any positional args. Why? As it is, code in the wild has become quite confusing where positional args are being passed to `collect()` and silently ignored. I'm looking at how to propose improving this part of sparta but I wanted to start a discussion but first create a PR that will demonstrate that this behavior isn't considered a throwable conidtion in latest sparta.
timsnyder
added
component: sparta
timsnyder
commented
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening a PR for this because it is the easiest way to see if the added test still fails with latest sparta without creating an updated env locally.
I would expect that
pevent.collect()should throw if called positional arguments that are:The test added in this PR shows that we can call
collect()with positional args for events that haven't registered any positional args. Why?As it is, code in the wild has become quite confusing where positional args are being passed to
collect()and silently ignored. I'm looking at how to propose improving this part of sparta but I wanted to start a discussion but first create a PR that will demonstrate that this behavior isn't considered a throwable conidtion in latest sparta.