Provide a way to append arch-specific stats to report definitions #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klingaard
reviewed
Jul 28, 2024
There was a problem hiding this comment.
Wonder if there's value in adding arch-content as a constexpr string (keyword) like content: KEY_ARCH_CONTENT. Of course, you still need to perform the find operation as expected
| if (auto sim_config = sim->getSimulationConfiguration()) { | ||
| skip_content_leaves_ = true; | ||
| bool dash_arch_given = false; | ||
| for (const auto &kvp : sim_config->getRunMetadata()) { |
There was a problem hiding this comment.
Might be handy to have sim config to enable a search of a key.
|
I don't know what's going on with azure. |
|
All regressions passed locally (by hand). I'll merge this in for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a fix for this issue:
#507