Argos compatibility fixes for GTK3 and wxPython 4.1.0 #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure why this test is failing. Regression passes on my machine. |
ghost
approved these changes
Oct 7, 2020
ghost
merged commit
github-actions bot
pushed a commit
that referenced
this pull request
Oct 7, 2020
Argos compatibility fixes for GTK3 and wxPython 4.1.0 9cf12e1
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes Argos compatible with GTK3 and the latest version of wxPython (4.1.0). It also includes a workaround for #200 (see #200 (comment) for details).
I've tested this locally against GTK2, GTK3, and OS X, but it would be nice if someone else could take a test drive on their setup and make sure things still work.