New IDE implementation #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@colby-nyce what use case have you found where a pre/post execute Observer Action will return a fail Action? |
kathlenemagnus
approved these changes
Jan 17, 2025
|
The fail action group code path would be used often by the IDE to tell the C++ sim not to evaluate a particular inst handler. |
| @@ -350,6 +366,51 @@ namespace atlas | |||
| return 0; | |||
| } | |||
|
|
|||
| sparta::Register* AtlasState::findRegister(const std::string & reg_name) const | |||
There was a problem hiding this comment.
Does the register name here have a prefix like "x" or "f"? If so, this method can probably be a little smarter and use the prefix to determine the register type.
| } | ||
| } | ||
|
|
||
| return nullptr; |
There was a problem hiding this comment.
Should this be an error instead? Seems like it would be bad if a register didn't exist at all.
| } | ||
| } | ||
|
|
||
| void AtlasState::cleanup() |
There was a problem hiding this comment.
Any reason this can't be included in the destructor?
kathlenemagnus-mips
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.