Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider Including Sparta as a Submodule #34

Open
kathlenemagnus opened this issue Dec 18, 2024 · 1 comment
Open

Consider Including Sparta as a Submodule #34

kathlenemagnus opened this issue Dec 18, 2024 · 1 comment

Comments

@kathlenemagnus
Copy link
Collaborator

Currently Atlas supports 2 methods of including the Sparta lib. Option 1 is to use the Sparta library installed in the user's Conda env. Option 2 is to provide Atlas with the path to the Sparta repo and building it with Atlas.

Since the Sparta library itself doesn't take too long to build, we should consider just including Sparta as a submodule. Need to investigate whether there are any downsides to this approach.

@knute-mips
Copy link
Contributor

knute-mips commented Dec 19, 2024

😬

I'd discourage this for a few reasons:

  1. Sparta shouldn't be changing that frequently. Not sure why this is necessary...
  2. This could potentially cause divergence between a user's installed version of sparta, Atlas' version of sparta, and if folks get into the habit of "submoduling" sparta, there will be LOTS of versions floating around. As a sparta developer this terrifies me
  3. This will increase build times for Atlas (albeit Sparta should be built once and with ccmake this should be painless). But still, that's a lot of disk space being used for common stuff

Instead of a submodule -- maybe an external project?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants