[SCSB-155] build with Numpy 2.0 release candidate #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharyburnett
changed the title
numpy>=2.0.0rc2 in build-system.requires
|
devdeps tests pass with |
mcara
approved these changes
Jun 8, 2024
Merged
zacharyburnett
added a commit
to zacharyburnett/spherical_geometry
that referenced
this pull request
Jun 12, 2024
mcara
pushed a commit
that referenced
this pull request
Jun 13, 2024
* freeze change log * add change log entry for #279
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #279 +/- ##
==========================================
- Coverage 80.33% 80.25% -0.08%
==========================================
Files 5 5
Lines 1017 1013 -4
==========================================
- Hits 817 813 -4
Misses 200 200 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves SCSB-155
Numpy 2.0 is scheduled for release on June 19th. Due to the C ABI updates, Python projects that build C extensions are required to build against Numpy 2.0 in order to use Numpy 2.0 in runtime.
This is backwards-compatible with Numpy versions in runtime as far back as
1.26this PR pins
numpy>=2.0.0rc2inbuild-system.requiresNote
this PR was generated automatically by
batchpr🤖