-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update update_monitor_table() to use django models #1659
Update update_monitor_table() to use django models #1659
Conversation
Hello @bhilbert4, Thank you for updating !
Comment last updated at 2025-01-28 02:38:00 UTC |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, do we need to add a migration for update_monitor_table?
I see, this answers my question 😆 |
@bhilbert4 #1666 is in, waiting on the rebase and then we can merge this too 💯 |
I still need to create the migration file for this one... |
Of course, I am having PR merging tunnel vision 😵💫 |
I just ran the wisp monitor (locally) using the updated code in this PR, and I can see the new entry in the Monitor database table. All looks good. I got a warning about datetime objects with no timezone, but I think that's something to be fixed in the wisp monitor in a separate PR. I think this PR is good to go. |
Nice, that is typical something to do with a datetime field entry from my experience. |
Update the update_monitor_table function, which is called by most (all?) monitors and records the date and success or failure of a monitor run, to use Django models.
This PR involves an update to the definition of the status column in the table, and therefore will need a migration attached to it.
Resolves #1485