-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Bad Pixel Monitor to use Django DB Models #1497
Update Bad Pixel Monitor to use Django DB Models #1497
Conversation
Hello @mfixstsci, Thank you for updating !
Comment last updated at 2024-11-12 19:14:12 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me. What about in monitor_bad_pixel_bokeh.py? That should be querying the database in order to produce the plots, right?
@bhilbert4 you are right, I just looked at the file. I will go ahead and update it. |
@bhilbert4 okay, so the updates to |
…que_values_per_column function
With @york-stsci 's updates are we prepared to merge? @bhilbert4 would you like to review the changes with Brian's changes in? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I hope you used a tool like Black rather than changing all those single quotes to double quotes manually. :)
The only issue is that the migration file needs to be included.
jwql/website/apps/jwql/monitor_pages/monitor_bad_pixel_bokeh.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for clearing up the empty defaults!
Looks good |
No description provided.