Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Bad Pixel Monitor to use Django DB Models #1497

Merged
merged 14 commits into from
Nov 12, 2024

Conversation

mfixstsci
Copy link
Collaborator

No description provided.

@pep8speaks
Copy link

pep8speaks commented Mar 11, 2024

Hello @mfixstsci, Thank you for updating !

Line 285:62: W291 trailing whitespace
Line 289:25: E127 continuation line over-indented for visual indent

Comment last updated at 2024-11-12 19:14:12 UTC

@mfixstsci mfixstsci changed the title WIP Update Bad Pixel Monitor to use Django DB Models Update Bad Pixel Monitor to use Django DB Models Mar 11, 2024
Copy link
Collaborator

@bhilbert4 bhilbert4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me. What about in monitor_bad_pixel_bokeh.py? That should be querying the database in order to produce the plots, right?

@mfixstsci
Copy link
Collaborator Author

These changes look good to me. What about in monitor_bad_pixel_bokeh.py? That should be querying the database in order to produce the plots, right?

@bhilbert4 you are right, I just looked at the file. I will go ahead and update it.

@mfixstsci
Copy link
Collaborator Author

@bhilbert4 okay, so the updates to monitor_bad_pixel_bokeh.py are in. I think should do it, let me know if I missed anything.

@mfixstsci
Copy link
Collaborator Author

With @york-stsci 's updates are we prepared to merge? @bhilbert4 would you like to review the changes with Brian's changes in?

Copy link
Collaborator

@bhilbert4 bhilbert4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I hope you used a tool like Black rather than changing all those single quotes to double quotes manually. :)

The only issue is that the migration file needs to be included.

Copy link
Collaborator

@bhilbert4 bhilbert4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for clearing up the empty defaults!

@york-stsci
Copy link
Collaborator

Looks good

@mfixstsci mfixstsci merged commit 0aff032 into spacetelescope:develop Nov 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants