Consolidate shared UI into ServerList control #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Currently both the servers and home tabs contain markup for displaying a server list, this adds a new control which is used by both to remove the duplication. NOTE: This currently omits the "Go to the servers tab" button which floats at the bottom of the favourites list.
User is expected to provide null/empty if text should not be visible.
ciaran
force-pushed
the
server-list-control
branch
from
c74b0b8 to
db34481
Compare
Currently this panel when open will obscure the server list scrollview behind it. This changes fixes the layout to stack the two panels vertically as you’d expect.
Enabled only for debug builds.
ciaran
force-pushed
the
server-list-control
branch
from
5f66460 to
0921323
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there are two views displaying a server list with duplicate layout required, this consolidates the server lists into a single control which is shared by the two views.
The expectation is that all current layout and behaviour is unchanged (aside from the message when a filter has no results now being shown as an incidental change).