Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vision_msgs to demo deps (#87) #97

Merged
merged 1 commit into from
Dec 28, 2023
Merged

Conversation

EzraBrooks
Copy link
Member

@EzraBrooks EzraBrooks commented Dec 28, 2023

This source dependency is missing and failing the build. Closes #87.

type: git
url: https://github.com/ros-perception/vision_msgs.git
version: 4.1.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we should redo this whole file to be version pinned, but while it's all done via tag we should probably follow suit to ensure compatibility with upstream.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@EzraBrooks EzraBrooks force-pushed the add-vision-msgs-to-demos branch from 708b13a to 925849e Compare December 28, 2023 20:31
@EzraBrooks EzraBrooks requested a review from Bckempa December 28, 2023 20:34
@Bckempa Bckempa added this to the humble-2024.01.0 milestone Dec 28, 2023
Copy link
Contributor

@Bckempa Bckempa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this gets space_robots to build cleanly we're good to go.

@EzraBrooks EzraBrooks merged commit 91b8e7a into main Dec 28, 2023
3 checks passed
@EzraBrooks EzraBrooks deleted the add-vision-msgs-to-demos branch December 28, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Vision_msgs not present when building space_robots image causing it to fail
2 participants