Pin demos to humble-2024.10.0 release (#197) #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current dockerfile of the moveit2 demo depends on space-ros:latest. This may prevent the image from building if we release a new version of Space ROS but we have not yet adapted the MoveIt 2 demo as needed, breaking the build. This commit pins the version of the MoveIt 2 demo to the latest version of Space ROS that we have tested it with (humble-2024.10.0). We modify both the Dockerfile and the build script so that the result is the same (and thus unsurprising) no matter how the image is built.
The current dockerfile of the navigation2 demo depends on space-ros:latest. This may prevent the image from building if we release a new version of Space ROS but we have not yet adapted the Navigation 2 demo as needed, breaking the build. This commit pins the version of the Navigation 2 demo to the latest version of Space ROS that we have tested it with (humble-2024.10.0). We modify both the Dockerfile and the build script so that the result is the same (and thus unsurprising) no matter how the image is built.
ivanperez-keera
force-pushed
the
pin-demos-spaceros-humble
branch
from
7431652 to
7126d6d
Compare
|
Thanks,confirmed this pins both the moveit and nav stacks to the last known working version which will implicitly keep space robots on a working config. |
Bckempa
approved these changes
Jan 31, 2025
|
@EzraBrooks, FYI one of the required CI checks didn't auto-fire. I manually started the |
|
There is a successful build of this, but it isn't acknowledged by the merge requirements: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current dockerfile of the MoveIt 2 and navigation2 demo depends on space-ros:latest. This may prevent the image from building if we release a new version of Space ROS but we have not yet adapted the either demo as needed, breaking the build.
This commit pins the version of both demos to the latest version of Space ROS that we have tested it with (humble-2024.10.0).