Fix renode rcc build failure (close #170)

[Bckempa]

The upstream repository used by this Dockerfile updated their internal dependencies (antmicro/renode-rtems-leon3@4e962e4) which are referenced by version number here:

docker/renode_rcc/Dockerfile

Line 39 in ad020b8

RUN mv grlib-gpl-2021.2-b4267 /opt/renode/

I considered pinning the upstream version given the magic-numbers at play, but because git doesn't support cloning by commit hash, (and the upstream works without branches, tags, or releases), I opted to just fix the bug at hand and leave detection of future issues to the already open #69

[Bckempa]

Annoyingly, it will auto-block the merge even though none of the CI docker builds use this directory 🙄

@gmacario, care to test this out and report back?

[gmacario]

@gmacario, care to test this out and report back?

With great pleasure 😃

Logged in as gmacario@hw2482, type the following commands:

cd ~/github/space-ros/docker/renode_rcc
git fetch --all --prune
git checkout 170-renode_rcc-failure-to-build-docker-image
./build.sh

Result: OK

gmacario@hw2482:~/github/space-ros/docker/renode_rcc$ git checkout 170-renode_rcc-failure-to-build-docker-image
Switched to branch '170-renode_rcc-failure-to-build-docker-image'
Your branch is up to date with 'origin/170-renode_rcc-failure-to-build-docker-image'.
gmacario@hw2482:~/github/space-ros/docker/renode_rcc$ ./build.sh

##### Building Renode Docker Image #####
[+] Building 49.8s (19/19) FINISHED                                           docker:default
 => [internal] load build definition from Dockerfile                                    0.0s
 => => transferring dockerfile: 1.51kB                                                  0.0s
 => [internal] load metadata for docker.io/library/ubuntu:20.04                         0.9s
 => [internal] load .dockerignore                                                       0.0s
 => => transferring context: 2B                                                         0.0s
 => [stage-0  1/14] FROM docker.io/library/ubuntu:20.04@sha256:fa17826afb526a9fc7250e0  0.0s
 => [internal] load build context                                                       0.0s
 => => transferring context: 220B                                                       0.0s
 => CACHED [stage-0  2/14] WORKDIR /root                                                0.0s
 => CACHED [stage-0  3/14] RUN --mount=type=cache,target=/var/cache/apt,sharing=locked  0.0s
 => CACHED [stage-0  4/14] RUN --mount=type=cache,target=/var/cache/apt,sharing=locked  0.0s
 => CACHED [stage-0  5/14] RUN pip3 install -r /opt/renode/tests/requirements.txt --no  0.0s
 => CACHED [stage-0  6/14] RUN git clone https://github.com/antmicro/renode-rtems-leon  0.0s
 => CACHED [stage-0  7/14] COPY renode-rtems-leon3/ /root/renode-rtems-leon3/           0.0s
 => CACHED [stage-0  8/14] WORKDIR /root/renode-rtems-leon3                             0.0s
 => CACHED [stage-0  9/14] RUN ./build-rtems.sh                                         0.0s
 => CACHED [stage-0 10/14] RUN ./build-prom.sh                                          0.0s
 => CACHED [stage-0 11/14] RUN mv rcc-1.3.0-gcc/ /opt/renode/                           0.0s
 => [stage-0 12/14] RUN mv grlib-gpl-2024.1-b4291 /opt/renode/                         10.6s
 => [stage-0 13/14] WORKDIR /root                                                       0.0s
 => [stage-0 14/14] COPY config .config/renode/                                         0.0s
 => exporting to image                                                                 38.0s
 => => exporting layers                                                                38.0s
 => => writing image sha256:0d3acfedb383738e61e56e1a329e05ef5db5eb33b4f71d61940ef942ac  0.0s
 => => naming to docker.io/openrobotics/renode:latest                                   0.0s

##### Done! #####
gmacario@hw2482:~/github/space-ros/docker/renode_rcc$

Inspect the resulting image:

gmacario@hw2482:~/github/space-ros/docker/renode_rcc$ docker images openrobotics/renode:latest
REPOSITORY            TAG       IMAGE ID       CREATED              SIZE
openrobotics/renode   latest    0d3acfedb383   About a minute ago   8.63GB
gmacario@hw2482:~/github/space-ros/docker/renode_rcc$

[gmacario]

@gmacario, care to test this out and report back?

With great pleasure 😃

...

Hello!
Is there anything else which I should do before this PR gets merged?

IMHO this PR fixes Bug #170 which I reported a few weeks ago.

[gmacario]

As already stated in #171 (comment) and #171 (comment) LGTM