Report annotation syntax error #1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soutaro
force-pushed
the
report-annotation-syntax-error
branch
from
2f861a3 to
b5aef80
Compare
ydah
added a commit
to ydah/lrama
that referenced
this pull request
Dec 9, 2024
The following changes caused the error. - soutaro/steep#1384 ``` lib/lrama/state/reduce.rb:30:36: [error] Type annotation has a syntax error: Failed to parse a type in annotation │ Diagnostic ID: Ruby::AnnotationSyntaxError │ └ # @type ivar @look_ahead: Array<Grammar::Symbol> ~~~~~~~~~~~~~~~~~~~~~~ ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syntax errors in annotation are reported as
SyntaxErrorinhintlevel and often overlooked. However, changing theSyntaxErrordiagnostic level doesn't make much sense, because the Ruby syntax error are usually uncovered by executing the program.This PR introduces a new diagnostic --
AnnotationSytaxError, which is dedicated to the syntax errors in annotations. We can assign more verboseerrorlevel to the error.