Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action fix: install dir should not contain /bin #251

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

kleinschmidt
Copy link
Contributor

This is a followup to #250. The install script seems to want the install root
and adds /bin to the install dir. This means that the action installs the
binary to ${HOME}/.local/bin/bin but adds ${HOME}/.local/bin to the path,
which at least in my workflow is not enough to pick up the installed binary!

@jviotti jviotti merged commit 33332e2 into sourcemeta:main Mar 6, 2025
6 of 7 checks passed
@jviotti
Copy link
Member

jviotti commented Mar 6, 2025

Thanks! I'm on the go now, but I'll release a new version first thing tomorrow. You can still probably point the action at the specific commit SHA in main in the mean-time!

@kleinschmidt
Copy link
Contributor Author

Many thanks for the quick response and maintaining such a useful tool!!

@jviotti
Copy link
Member

jviotti commented Mar 7, 2025

Any time @kleinschmidt ! Out of curiosity, how are you using JSON Schema? If there is anything I can do on the CLI or other tooling to make your life easier, just let me know :)

@kleinschmidt
Copy link
Contributor Author

Out of curiosity, how are you using JSON Schema?

We have some internal tools that our users need to write configuration files for, and validating that they conform to the schema is a great way to catch problems before we actually try to run a bad/incomplete/malformed config, and a great way to surface them in a human-readable way! It also provides documentation for the config format that is co-located with the definition of the format and helps avoid our docs getting out of sync.

@jviotti
Copy link
Member

jviotti commented Mar 7, 2025

@kleinschmidt Very nice! As good error messages might be important there, JSON Schema is planning to work a bit on the whole idea of error reporting on GSoC 2025 (json-schema-org/community#870). If you find this CLI (or any other validator) doesn't give you great error messages, please surface them as issues, as that will be a big area of focus soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants