fix: install in a different location for github actions #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't seem to actually work in our workflows. It's installing to |
jviotti
pushed a commit
that referenced
this pull request
Mar 6, 2025
This is a followup to #250. The install script seems to want the install root and adds `/bin` to the install dir. This means that the action installs the binary to `${HOME}/.local/bin/bin` but adds `${HOME}/.local/bin` to the path, which at least in my workflow is not enough to pick up the installed binary!
|
Ah, good catch. Makes sense now that I see the scripts again. Please try v7.0.2. I just published it with the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something has changed in the /usr/local/bin permission
However, GitHub actions can modify on the fly the PATH using the GITHUB_PATH env variable as explained in https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/workflow-commands-for-github-actions#adding-a-system-path
Part of #249