Skip to content

Commit

Permalink
Improve dialect and bundling related error messages (#239)
Browse files Browse the repository at this point in the history
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
  • Loading branch information
jviotti authored Mar 3, 2025
1 parent 9273c01 commit f41dafb
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 7 deletions.
2 changes: 1 addition & 1 deletion DEPENDENCIES
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
vendorpull https://github.com/sourcemeta/vendorpull dea311b5bfb53b6926a4140267959ae334d3ecf4
core https://github.com/sourcemeta/core 0b28a374ececfdede7cdef409327ec016a9089c9
core https://github.com/sourcemeta/core 7cc3d4d7070abc6f76615230264cc260bc71c6fc
hydra https://github.com/sourcemeta/hydra a67b879df800e834ed8a2d056f98398f7211d870
jsonbinpack https://github.com/sourcemeta/jsonbinpack c7bb7f4d903c3b6925b62ce2bb5b8d360e01ce84
blaze https://github.com/sourcemeta/blaze bf456d47dfd7fc51f077da268412735b4c6f9fa7
2 changes: 1 addition & 1 deletion test/test/fail_resolve_directory_non_schema.sh
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ test "$CODE" = "1" || exit 1
cat << EOF > "$TMP/expected.txt"
Importing schema into the resolution context: $(realpath "$TMP")/schemas/schema.json
Importing schema into the resolution context: $(realpath "$TMP")/schemas/test.json
error: Cannot determine the base dialect of the schema
error: Could not determine the base dialect of the schema
EOF

diff "$TMP/output.txt" "$TMP/expected.txt"
2 changes: 1 addition & 1 deletion vendor/core/src/core/jsonschema/bundle.cc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion vendor/core/src/core/jsonschema/frame.cc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions vendor/core/src/core/jsonschema/jsonschema.cc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit f41dafb

Please sign in to comment.